LPS-125854 Fix XSS validating context and encoding HTML - #98059
Closed
wincent wants to merge 5 commits into
Closed
Conversation
As requested here:
#97915 (comment)
Note that in the related PR we discussed whether to apply a different
fix on master (ie. removing the vulnerable file, vs patching it on older
branches), but in the end it is less work overall just to patch
everywhere.
Collaborator
|
Closing pull request because all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on liferay-frontend#699
This is a POC for what a download-and-patch workflow might look like for jquery.form — it's pretty hideous though (ie. committing a patch file), and I would need to tweak it to actually make it work robustly. In my testing I had a lot of trouble fighting with the Gradle cache; at one point it decided that the file should be empty and then started recreating the empty file instead of downloading it 🤦♂️. I also found that
onlyIfblocks don't seem to work reliably withCopytasks; Gradle seems to want to run them no matter what, irrespective of whether the block returnsfalse.